KVM: VMX: Rename IA32_FEATURE_CONTROL bits
authorSheng Yang <sheng.yang@intel.com>
Thu, 11 Sep 2008 07:27:49 +0000 (15:27 +0800)
committerAvi Kivity <avi@qumranet.com>
Wed, 15 Oct 2008 08:16:14 +0000 (10:16 +0200)
Signed-off-by: Sheng Yang <sheng.yang@intel.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
arch/x86/kvm/vmx.c
arch/x86/kvm/vmx.h

index f8e615fc87441f29410040d2d1b7735046e7f0e6..046a91b5a4baadbecec86b9761fa2f4f2540003f 100644 (file)
@@ -1041,9 +1041,9 @@ static __init int vmx_disabled_by_bios(void)
        u64 msr;
 
        rdmsrl(MSR_IA32_FEATURE_CONTROL, msr);
-       return (msr & (IA32_FEATURE_CONTROL_LOCKED_BIT |
-                      IA32_FEATURE_CONTROL_VMXON_ENABLED_BIT))
-           == IA32_FEATURE_CONTROL_LOCKED_BIT;
+       return (msr & (FEATURE_CONTROL_LOCKED |
+                      FEATURE_CONTROL_VMXON_ENABLED))
+           == FEATURE_CONTROL_LOCKED;
        /* locked but not enabled */
 }
 
@@ -1055,14 +1055,14 @@ static void hardware_enable(void *garbage)
 
        INIT_LIST_HEAD(&per_cpu(vcpus_on_cpu, cpu));
        rdmsrl(MSR_IA32_FEATURE_CONTROL, old);
-       if ((old & (IA32_FEATURE_CONTROL_LOCKED_BIT |
-                   IA32_FEATURE_CONTROL_VMXON_ENABLED_BIT))
-           != (IA32_FEATURE_CONTROL_LOCKED_BIT |
-               IA32_FEATURE_CONTROL_VMXON_ENABLED_BIT))
+       if ((old & (FEATURE_CONTROL_LOCKED |
+                   FEATURE_CONTROL_VMXON_ENABLED))
+           != (FEATURE_CONTROL_LOCKED |
+               FEATURE_CONTROL_VMXON_ENABLED))
                /* enable and lock */
                wrmsrl(MSR_IA32_FEATURE_CONTROL, old |
-                      IA32_FEATURE_CONTROL_LOCKED_BIT |
-                      IA32_FEATURE_CONTROL_VMXON_ENABLED_BIT);
+                      FEATURE_CONTROL_LOCKED |
+                      FEATURE_CONTROL_VMXON_ENABLED);
        write_cr4(read_cr4() | X86_CR4_VMXE); /* FIXME: not cpu hotplug safe */
        asm volatile (ASM_VMX_VMXON_RAX
                      : : "a"(&phys_addr), "m"(phys_addr)
index 86059f439cb4af389ef540a2dd9464fd608e1b24..44cfab706443936aa733428c46703fcc908d9350 100644 (file)
@@ -331,8 +331,8 @@ enum vmcs_field {
 
 #define AR_RESERVD_MASK 0xfffe0f00
 
-#define IA32_FEATURE_CONTROL_LOCKED_BIT                0x1
-#define IA32_FEATURE_CONTROL_VMXON_ENABLED_BIT 0x4
+#define FEATURE_CONTROL_LOCKED             (1<<0)
+#define FEATURE_CONTROL_VMXON_ENABLED      (1<<2)
 
 #define APIC_ACCESS_PAGE_PRIVATE_MEMSLOT       9
 #define IDENTITY_PAGETABLE_PRIVATE_MEMSLOT     10