"xfs: fix error handling for synchronous writes" revisited
authorAjeet Yadav <ajeet.yadav.77@gmail.com>
Fri, 29 Jul 2011 07:42:59 +0000 (07:42 +0000)
committerAlex Elder <aelder@sgi.com>
Wed, 10 Aug 2011 22:00:21 +0000 (17:00 -0500)
xfs: fix for hang during synchronous buffer write error

If removed storage while synchronous buffer write underway,
"xfslogd" hangs.

Detailed log http://oss.sgi.com/archives/xfs/2011-07/msg00740.html

Related work bfc60177f8ab509bc225becbb58f7e53a0e33e81
"xfs: fix error handling for synchronous writes"

Given that xfs_bwrite actually does the shutdown already after
waiting for the b_iodone completion and given that we actually
found that calling xfs_force_shutdown from inside
xfs_buf_iodone_callbacks was a major contributor the problem
it better to drop this call.

Signed-off-by: Ajeet Yadav <ajeet.yadav.77@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/xfs_buf_item.c

index 0402173e79e9dc6a5f662c1b863fe02dd95a9e77..cac2ecfa674684762cce50d5acd323f79b8b4d5a 100644 (file)
@@ -1010,7 +1010,6 @@ xfs_buf_iodone_callbacks(
        XFS_BUF_UNDELAYWRITE(bp);
 
        trace_xfs_buf_error_relse(bp, _RET_IP_);
-       xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR);
 
 do_callbacks:
        xfs_buf_do_callbacks(bp);