Revert "gpiolib: request the gpio before querying its direction"

This reverts commit 108d23e322a247d9f89ba2e2742520ead0944cc9.
It turns out this causes a regression on the OMAP, Marvell
and Renesas.

Reported-by: Tony Lindgren <tony@atomide.com>
Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reported-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index e452768f316d5fcb68ff6adfe090052882c71cb8..eb80dac4e26a52e6f18a4652d3c7fb03451b516a 100644 (file)
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1221,14 +1221,6 @@ int gpiochip_add_data(struct gpio_chip *chip, void *data)
                struct gpio_desc *desc = &gdev->descs[i];
 
                desc->gdev = gdev;
-
-               if (chip->request) {
-                       status = chip->request(chip, i);
-                       if (status < 0)
-                               /* The GPIO is unavailable, so skip it */
-                               continue;
-               }
-
                /*
                 * REVISIT: most hardware initializes GPIOs as inputs
                 * (often with pullups enabled) so power usage is
@@ -1254,9 +1246,6 @@ int gpiochip_add_data(struct gpio_chip *chip, void *data)
                         */
                        set_bit(FLAG_IS_OUT, &desc->flags);
                }
-
-               if (chip->free)
-                       chip->free(chip, i);
        }
 
 #ifdef CONFIG_PINCTRL