smsc9420: fix another postfixed timeout
authorSteve Glendinning <steve.glendinning@smsc.com>
Mon, 16 Feb 2009 07:46:06 +0000 (07:46 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Feb 2009 08:35:08 +0000 (00:35 -0800)
Roel Kluin recently fixed several instances where variables reach -1,
but 0 is tested afterwards.  This patch fixes another, so the timeout
will be correctly detected and a warning printed.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/smsc9420.c

index a1e4b3895b339d0a007ec07483e6039bf1d212d0..83938e1953b0c693a6fcb4e159978f5b799e6bd7 100644 (file)
@@ -341,7 +341,7 @@ static int smsc9420_eeprom_send_cmd(struct smsc9420_pdata *pd, u32 op)
        do {
                msleep(1);
                e2cmd = smsc9420_reg_read(pd, E2P_CMD);
-       } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (timeout--));
+       } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (--timeout));
 
        if (!timeout) {
                smsc_info(HW, "TIMED OUT");