NFS: Remove unnecessary goto in nfs4_lookup_root_sec()
authorAnna Schumaker <Anna.Schumaker@Netapp.com>
Wed, 11 Jan 2017 21:30:08 +0000 (16:30 -0500)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Mon, 30 Jan 2017 18:14:50 +0000 (13:14 -0500)
Once again, it's easier and cleaner just to return the error directly.

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/nfs4proc.c

index baf9689904752197cd5d092a01b6d87cbd5447d5..6c40944cb83de777be1d6fbbc547ac9aea95552a 100644 (file)
@@ -3416,16 +3416,11 @@ static int nfs4_lookup_root_sec(struct nfs_server *server, struct nfs_fh *fhandl
                .pseudoflavor = flavor,
        };
        struct rpc_auth *auth;
-       int ret;
 
        auth = rpcauth_create(&auth_args, server->client);
-       if (IS_ERR(auth)) {
-               ret = -EACCES;
-               goto out;
-       }
-       ret = nfs4_lookup_root(server, fhandle, info);
-out:
-       return ret;
+       if (IS_ERR(auth))
+               return -EACCES;
+       return nfs4_lookup_root(server, fhandle, info);
 }
 
 /*