ath10k: fix debugfs pktlog_filter write
authorAnilkumar Kolli <akolli@qti.qualcomm.com>
Fri, 11 Mar 2016 06:16:39 +0000 (11:46 +0530)
committerKalle Valo <kvalo@qca.qualcomm.com>
Fri, 18 Mar 2016 07:57:11 +0000 (09:57 +0200)
It is observed that, we are disabling the packet log if we write same
value to the pktlog_filter for the second time. Always enable pktlogs
on non zero filter.

Fixes: 90174455ae05 ("ath10k: add support to configure pktlog filter")
Cc: stable@vger.kernel.org
Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath10k/debug.c

index 076d29b53ddff67a5b687dc6b722632db20d111c..0f834646e6a79e994bd9f34558d105828623d1ed 100644 (file)
@@ -2019,7 +2019,12 @@ static ssize_t ath10k_write_pktlog_filter(struct file *file,
                goto out;
        }
 
-       if (filter && (filter != ar->debug.pktlog_filter)) {
+       if (filter == ar->debug.pktlog_filter) {
+               ret = count;
+               goto out;
+       }
+
+       if (filter) {
                ret = ath10k_wmi_pdev_pktlog_enable(ar, filter);
                if (ret) {
                        ath10k_warn(ar, "failed to enable pktlog filter %x: %d\n",