drm/i915/glk: Fix DSI enable I/O sequence
authorMadhav Chauhan <madhav.chauhan@intel.com>
Wed, 1 Mar 2017 18:31:22 +0000 (00:01 +0530)
committerJani Nikula <jani.nikula@intel.com>
Thu, 2 Mar 2017 14:34:13 +0000 (16:34 +0200)
One of the if statement covers the next line in enable I/O sequence.
This patch correct the same by adding error message.

Fixes: 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable sequence")
Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Madhav Chauhan <madhav.chauhan@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1488393082-30660-1-git-send-email-madhav.chauhan@intel.com
drivers/gpu/drm/i915/intel_dsi.c

index dd38b683552886b3974892af3a969408e7f473b5..323fc097c3ee45507ba56efe000a98b2966b266e 100644 (file)
@@ -425,6 +425,7 @@ static void glk_dsi_device_ready(struct intel_encoder *encoder)
                if (intel_wait_for_register(dev_priv,
                                MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
                                GLK_ULPS_NOT_ACTIVE, 20))
+                       DRM_ERROR("ULPS is still active\n");
 
                /* Exit ULPS */
                val = I915_READ(MIPI_DEVICE_READY(port));