projects
/
GitHub
/
exynos8895
/
android_kernel_samsung_universal8895.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4c88b7f
)
ALSA: lola: Fix uninitialized variable access in error message
author
Takashi Iwai
<tiwai@suse.de>
Tue, 29 Oct 2013 15:51:36 +0000
(16:51 +0100)
committer
Takashi Iwai
<tiwai@suse.de>
Tue, 29 Oct 2013 15:51:36 +0000
(16:51 +0100)
The FUNCTION_TYPE parameter isn't associated with any NID, thus
showing the uninitialized nid in the error message is simply
nonsense.
Spotted by coverity CID 145068.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/lola/lola.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/pci/lola/lola.c
b/sound/pci/lola/lola.c
index 7307d97186cb45c66f7584f9857c559533038f72..0568540dc8d353995879ba6ab26be56360b164e4 100644
(file)
--- a/
sound/pci/lola/lola.c
+++ b/
sound/pci/lola/lola.c
@@
-463,7
+463,7
@@
static int lola_parse_tree(struct lola *chip)
err = lola_read_param(chip, 1, LOLA_PAR_FUNCTION_TYPE, &val);
if (err < 0) {
- printk(KERN_ERR SFX "Can't read FUNCTION_TYPE
for 0x%x\n", nid
);
+ printk(KERN_ERR SFX "Can't read FUNCTION_TYPE
\n"
);
return err;
}
if (val != 1) {