ASoC: fsl-sai: don't set bclk for Tx/Rx Synchronous with another SAI mode
authorZidan Wang <zidan.wang@freescale.com>
Mon, 9 Nov 2015 11:02:29 +0000 (19:02 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 17 Nov 2015 18:51:36 +0000 (18:51 +0000)
In fsl_sai_set_bclk function, we should not set bclk for Tx/Rx Synchronous
with another SAI mode.

Signed-off-by: Zidan Wang <zidan.wang@freescale.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_sai.c

index a4435f5e3be910447f9168b4708d19140f3c1f4f..7e421a97c09067ef7f2d5550deb5a8a03880ac79 100644 (file)
@@ -354,13 +354,25 @@ static int fsl_sai_set_bclk(struct snd_soc_dai *dai, bool tx, u32 freq)
                return -EINVAL;
        }
 
-       if ((tx && sai->synchronous[TX]) || (!tx && !sai->synchronous[RX])) {
+       /*
+        * 1) For Asynchronous mode, we must set RCR2 register for capture, and
+        *    set TCR2 register for playback.
+        * 2) For Tx sync with Rx clock, we must set RCR2 register for playback
+        *    and capture.
+        * 3) For Rx sync with Tx clock, we must set TCR2 register for playback
+        *    and capture.
+        * 4) For Tx and Rx are both Synchronous with another SAI, we just
+        *    ignore it.
+        */
+       if ((sai->synchronous[TX] && !sai->synchronous[RX]) ||
+           (!tx && !sai->synchronous[RX])) {
                regmap_update_bits(sai->regmap, FSL_SAI_RCR2,
                                   FSL_SAI_CR2_MSEL_MASK,
                                   FSL_SAI_CR2_MSEL(sai->mclk_id[tx]));
                regmap_update_bits(sai->regmap, FSL_SAI_RCR2,
                                   FSL_SAI_CR2_DIV_MASK, savediv - 1);
-       } else {
+       } else if ((sai->synchronous[RX] && !sai->synchronous[TX]) ||
+                  (tx && !sai->synchronous[TX])) {
                regmap_update_bits(sai->regmap, FSL_SAI_TCR2,
                                   FSL_SAI_CR2_MSEL_MASK,
                                   FSL_SAI_CR2_MSEL(sai->mclk_id[tx]));