staging: ccree: fix array_size.cocci warnings
authorkbuild test robot <lkp@intel.com>
Sun, 23 Apr 2017 09:26:21 +0000 (12:26 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Apr 2017 10:17:54 +0000 (12:17 +0200)
drivers/staging/ccree/ssi_sysfs.c:319:34-35: WARNING: Use ARRAY_SIZE
drivers/staging/ccree/ssi_sysfs.c:429:34-35: WARNING: Use ARRAY_SIZE

 Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element

Semantic patch information:
 This makes an effort to find cases where ARRAY_SIZE can be used such as
 where there is a division of sizeof the array by the sizeof its first
 element or by any indexed element or the element type. It replaces the
 division of the two sizeofs by ARRAY_SIZE.

Generated by: scripts/coccinelle/misc/array_size.cocci

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ccree/ssi_sysfs.c

index 6db75730f53d488e6091ef8336485579a1957d04..7c514c1072a95e45e9590b0fd671e31612fb01a7 100644 (file)
@@ -316,7 +316,7 @@ static ssize_t ssi_sys_help_show(struct kobject *kobj,
        int i=0, offset = 0;
 
        offset += scnprintf(buf + offset, PAGE_SIZE - offset, "Usage:\n");
-       for ( i = 0; i < (sizeof(help_str)/sizeof(help_str[0])); i+=2) {
+       for ( i = 0; i < ARRAY_SIZE(help_str); i+=2) {
           offset += scnprintf(buf + offset, PAGE_SIZE - offset, "%s\t\t%s\n", help_str[i], help_str[i+1]);
        }
        return offset;
@@ -426,8 +426,7 @@ int ssi_sysfs_init(struct kobject *sys_dev_obj, struct ssi_drvdata *drvdata)
        /* Initialize top directory */
        retval = sys_init_dir(&sys_top_dir, drvdata, sys_dev_obj,
                                "cc_info", ssi_sys_top_level_attrs,
-                               sizeof(ssi_sys_top_level_attrs) /
-                               sizeof(struct kobj_attribute));
+                               ARRAY_SIZE(ssi_sys_top_level_attrs));
        return retval;
 }