drm/panel: s6e8aa0: silence array overflow warning
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Apr 2014 15:21:12 +0000 (18:21 +0300)
committerThierry Reding <treding@nvidia.com>
Thu, 5 Jun 2014 14:46:39 +0000 (16:46 +0200)
Smatch complains that we are reading beyond the end of the array here:

drivers/gpu/drm/panel/panel-s6e8aa0.c:852 s6e8aa0_read_mtp_id()
warn: buffer overflow 's6e8aa0_variants' 4 <= 4

We set the error code, so it's not harmful but it looks like a return
was intended here so lets add that and silence the warning.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/panel/panel-s6e8aa0.c

index 35941d2412b82882981709a3c44af8d834c71f38..06e57a26db7a5ed09561442aab1dfe840d770775 100644 (file)
@@ -847,6 +847,7 @@ static void s6e8aa0_read_mtp_id(struct s6e8aa0 *ctx)
        if (i >= ARRAY_SIZE(s6e8aa0_variants)) {
                dev_err(ctx->dev, "unsupported display version %d\n", id[1]);
                ctx->error = -EINVAL;
+               return;
        }
 
        ctx->variant = &s6e8aa0_variants[i];