alarmtimer: don't rate limit one-shot timers
authorGreg Hackmann <ghackmann@google.com>
Mon, 24 Jul 2017 17:19:24 +0000 (10:19 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jul 2017 22:06:10 +0000 (15:06 -0700)
Commit ff86bf0c65f1 ("alarmtimer: Rate limit periodic intervals") sets a
minimum bound on the alarm timer interval.  This minimum bound shouldn't
be applied if the interval is 0.  Otherwise, one-shot timers will be
converted into periodic ones.

Fixes: ff86bf0c65f1 ("alarmtimer: Rate limit periodic intervals")
Reported-by: Ben Fennema <fennema@google.com>
Signed-off-by: Greg Hackmann <ghackmann@google.com>
Cc: stable@vger.kernel.org
Cc: John Stultz <john.stultz@linaro.org>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/time/alarmtimer.c

index 2c3a23d7770459f9c1f15250ea456951eb568c30..6fcc367ad5314c47fde82d56b59b255bee53b45e 100644 (file)
@@ -616,7 +616,8 @@ static int alarm_timer_set(struct k_itimer *timr, int flags,
         * Rate limit to the tick as a hot fix to prevent DOS. Will be
         * mopped up later.
         */
-       if (ktime_to_ns(timr->it.alarm.interval) < TICK_NSEC)
+       if (timr->it.alarm.interval.tv64 &&
+                       ktime_to_ns(timr->it.alarm.interval) < TICK_NSEC)
                timr->it.alarm.interval = ktime_set(0, TICK_NSEC);
 
        exp = timespec_to_ktime(new_setting->it_value);