media: coda: do not reassign ctx->tiled_map_type in coda_s_fmt

This smatch warning:

    coda/coda-common.c:706 coda_s_fmt() warn: missing break? reassigning 'ctx->tiled_map_type'

can be silenced by moving the ctx->tiled_map_type assignment into the
breakout condition. That way the field is not reassigned when falling
through to the next switch statement.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c
index d119b477732826fb83954f522bdd77d8c67e51d3..90c061e504096d9e4825624c3b18cec49dffe474 100644 (file)
--- a/drivers/media/platform/coda/coda-common.c
+++ b/drivers/media/platform/coda/coda-common.c
@@ -714,9 +714,10 @@ static int coda_s_fmt(struct coda_ctx *ctx, struct v4l2_format *f,
                ctx->tiled_map_type = GDI_TILED_FRAME_MB_RASTER_MAP;
                break;
        case V4L2_PIX_FMT_NV12:
-               ctx->tiled_map_type = GDI_TILED_FRAME_MB_RASTER_MAP;
-               if (!disable_tiling)
+               if (!disable_tiling) {
+                       ctx->tiled_map_type = GDI_TILED_FRAME_MB_RASTER_MAP;
                        break;
+               }
                /* else fall through */
        case V4L2_PIX_FMT_YUV420:
        case V4L2_PIX_FMT_YVU420: