ath9k: Synchronize DMA transfer with CPU at right place
authorVasanthakumar Thiagarajan <vasanth@atheros.com>
Mon, 15 Dec 2008 15:10:46 +0000 (20:40 +0530)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 19 Dec 2008 20:23:26 +0000 (15:23 -0500)
This patch does pci_dma_sync_single_for_cpu() before accessing
the header of the frame and queueing the same buffer into h/w.

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath9k/recv.c

index cc160fe9f817609182681f6eed5ceed25248e24e..462e08c3d09dc4cf18693f4e39c383a7dc34c580 100644 (file)
@@ -519,6 +519,15 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush)
                if (!skb)
                        continue;
 
+               /*
+                * Synchronize the DMA transfer with CPU before
+                * 1. accessing the frame
+                * 2. requeueing the same buffer to h/w
+                */
+               pci_dma_sync_single_for_cpu(sc->pdev, bf->bf_buf_addr,
+                               sc->rx.bufsize,
+                               PCI_DMA_FROMDEVICE);
+
                /*
                 * If we're asked to flush receive queue, directly
                 * chain it back at the queue without processing it.
@@ -547,10 +556,7 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush)
                if (!requeue_skb)
                        goto requeue;
 
-               /* Sync and unmap the frame */
-               pci_dma_sync_single_for_cpu(sc->pdev, bf->bf_buf_addr,
-                                           sc->rx.bufsize,
-                                           PCI_DMA_FROMDEVICE);
+               /* Unmap the frame */
                pci_unmap_single(sc->pdev, bf->bf_buf_addr,
                                 sc->rx.bufsize,
                                 PCI_DMA_FROMDEVICE);