projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 4c83445)
md: make sure GET_ARRAY_INFO ioctl reports correct "clean" status
authorNeilBrown <neilb@suse.de>
Wed, 2 Jul 2014 01:35:06 +0000 (11:35 +1000)
committerNeilBrown <neilb@suse.de>
Thu, 3 Jul 2014 00:44:31 +0000 (10:44 +1000)
If an array has a bitmap, the when we set the "has bitmap" flag we
incorrectly clear the "is clean" flag.

"is clean" isn't really important when a bitmap is present, but it is
best to get it right anyway.

Reported-by: George Duffield <forumscollective@gmail.com>
Link: http://lkml.kernel.org/CAG__1a4MRV6gJL38XLAurtoSiD3rLBTmWpcS5HYvPpSfPR88UQ@mail.gmail.com
Fixes: 36fa30636fb84b209210299684e1be66d9e58217 (v2.6.14)
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/md.c patch | blob | blame | history

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 34846856dbc6106c95b81d948a4e41ad6e4d816d..817dbca6059e561284f367677ec890f71b98b001 100644 (file)
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5599,7 +5599,7 @@ static int get_array_info(struct mddev * mddev, void __user * arg)
        if (mddev->in_sync)
                info.state = (1<<MD_SB_CLEAN);
        if (mddev->bitmap && mddev->bitmap_info.offset)
-               info.state = (1<<MD_SB_BITMAP_PRESENT);
+               info.state |= (1<<MD_SB_BITMAP_PRESENT);
        info.active_disks  = insync;
        info.working_disks = working;
        info.failed_disks  = failed;