MIPS: Lasat: A couple off by one bugs in picvue_proc.c
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 8 Nov 2013 09:44:31 +0000 (12:44 +0300)
committerRalf Baechle <ralf@linux-mips.org>
Sat, 28 May 2016 10:35:06 +0000 (12:35 +0200)
These should be ">=" instead of ">" or we go past the end of the
pvc_lines[] array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-mips@linux-mips.org
Cc: kernel-janitors@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/6124/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/lasat/picvue_proc.c

index b420958806678a3b24b7b5b4c8d7dd4d393a7214..27533c109f928c9822eb5383e838906cbba8a744 100644 (file)
@@ -43,7 +43,7 @@ static int pvc_line_proc_show(struct seq_file *m, void *v)
 {
        int lineno = *(int *)m->private;
 
-       if (lineno < 0 || lineno > PVC_NLINES) {
+       if (lineno < 0 || lineno >= PVC_NLINES) {
                printk(KERN_WARNING "proc_read_line: invalid lineno %d\n", lineno);
                return 0;
        }
@@ -67,7 +67,7 @@ static ssize_t pvc_line_proc_write(struct file *file, const char __user *buf,
        char kbuf[PVC_LINELEN];
        size_t len;
 
-       BUG_ON(lineno < 0 || lineno > PVC_NLINES);
+       BUG_ON(lineno < 0 || lineno >= PVC_NLINES);
 
        len = min(count, sizeof(kbuf) - 1);
        if (copy_from_user(kbuf, buf, len))