iwlwifi: mvm: remove pointless _bh from spinlock in timer
authorJohannes Berg <johannes.berg@intel.com>
Wed, 3 Aug 2016 11:38:59 +0000 (13:38 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 16 Sep 2016 06:10:34 +0000 (09:10 +0300)
Inside the reorder timer expire function, there's no point in
disabling BHs since it is in BH context. Remove that.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

index 08d8a8abb9188590552cfbab852ba619b2f77d60..7845dbefb67a4eb0ab60f138486f3d1631ee1b30 100644 (file)
@@ -452,10 +452,10 @@ void iwl_mvm_reorder_timer_expired(unsigned long data)
        u16 sn = 0, index = 0;
        bool expired = false;
 
-       spin_lock_bh(&buf->lock);
+       spin_lock(&buf->lock);
 
        if (!buf->num_stored || buf->removed) {
-               spin_unlock_bh(&buf->lock);
+               spin_unlock(&buf->lock);
                return;
        }
 
@@ -492,7 +492,7 @@ void iwl_mvm_reorder_timer_expired(unsigned long data)
                          buf->reorder_time[index] +
                          1 + RX_REORDER_BUF_TIMEOUT_MQ);
        }
-       spin_unlock_bh(&buf->lock);
+       spin_unlock(&buf->lock);
 }
 
 static void iwl_mvm_del_ba(struct iwl_mvm *mvm, int queue,