NetCP: Deletion of unnecessary checks before two function calls

The functions cpsw_ale_destroy() and of_dev_put() test whether their argument
is NULL and then return immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c
index 345cd25637726284ebc6530af937866d77c4d474..84f5ce525750d2c44ea80194975c92602f5793b5 100644 (file)
--- a/drivers/net/ethernet/ti/netcp_ethss.c
+++ b/drivers/net/ethernet/ti/netcp_ethss.c
@@ -2011,12 +2011,10 @@ static int gbe_probe(struct netcp_device *netcp_device, struct device *dev,
 quit:
        if (gbe_dev->hw_stats)
                devm_kfree(dev, gbe_dev->hw_stats);
-       if (gbe_dev->ale)
-               cpsw_ale_destroy(gbe_dev->ale);
+       cpsw_ale_destroy(gbe_dev->ale);
        if (gbe_dev->ss_regs)
                devm_iounmap(dev, gbe_dev->ss_regs);
-       if (interfaces)
-               of_node_put(interfaces);
+       of_node_put(interfaces);
        devm_kfree(dev, gbe_dev);
        return ret;
 }