crypto: chcr - checking for IS_ERR() instead of NULL
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 1 Dec 2016 20:49:37 +0000 (23:49 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 7 Dec 2016 12:01:11 +0000 (20:01 +0800)
The create_hash_wr() function never returns error pointers.  It returns
NULL on error.

Fixes: 358961d1cd1e ("crypto: chcr - Added new structure chcr_wr")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/chelsio/chcr_algo.c

index e73b9809591d5124824d76155a6707b6f636f5cc..57b49ecdcad463757d1069c06d40989018e4741c 100644 (file)
@@ -956,9 +956,8 @@ static int chcr_ahash_update(struct ahash_request *req)
        req_ctx->result = 0;
        req_ctx->data_len += params.sg_len + params.bfr_len;
        skb = create_hash_wr(req, &params);
-
-       if (IS_ERR(skb))
-               return PTR_ERR(skb);
+       if (!skb)
+               return -ENOMEM;
 
        if (remainder) {
                u8 *temp;
@@ -1021,8 +1020,8 @@ static int chcr_ahash_final(struct ahash_request *req)
                params.more = 0;
        }
        skb = create_hash_wr(req, &params);
-       if (IS_ERR(skb))
-               return PTR_ERR(skb);
+       if (!skb)
+               return -ENOMEM;
 
        skb->dev = u_ctx->lldi.ports[0];
        set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);
@@ -1072,8 +1071,8 @@ static int chcr_ahash_finup(struct ahash_request *req)
        }
 
        skb = create_hash_wr(req, &params);
-       if (IS_ERR(skb))
-               return PTR_ERR(skb);
+       if (!skb)
+               return -ENOMEM;
 
        skb->dev = u_ctx->lldi.ports[0];
        set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);
@@ -1123,8 +1122,8 @@ static int chcr_ahash_digest(struct ahash_request *req)
        }
 
        skb = create_hash_wr(req, &params);
-       if (IS_ERR(skb))
-               return PTR_ERR(skb);
+       if (!skb)
+               return -ENOMEM;
 
        skb->dev = u_ctx->lldi.ports[0];
        set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);