perf test powerpc: Fix 'Object code reading' test
authorRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Thu, 31 Aug 2017 09:14:56 +0000 (14:44 +0530)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 1 Sep 2017 17:45:59 +0000 (14:45 -0300)
'Object code reading' test always fails on powerpc guest. Two reasons
for the failure are:

1. When elf section is too big (size beyond 'unsigned int' max value).
objdump fails to disassemble from such section. This was fixed with
commit 0f6329bd7fc ("binutils/objdump: Fix disassemble for huge elf
sections") in binutils.

2. When the sample is from hypervisor. Hypervisor symbols can not be
resolved within guest and thus thread__find_addr_map() fails for such
symbols. Fix this by ignoring hypervisor symbols in the test.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lkml.kernel.org/r/1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/code-reading.c

index 761c5a448c5607299d1801bd097329f9b5d9d34d..466a462b26d12996d3b694f9be256bcf8cfc1bb4 100644 (file)
@@ -237,6 +237,11 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode,
 
        thread__find_addr_map(thread, cpumode, MAP__FUNCTION, addr, &al);
        if (!al.map || !al.map->dso) {
+               if (cpumode == PERF_RECORD_MISC_HYPERVISOR) {
+                       pr_debug("Hypervisor address can not be resolved - skipping\n");
+                       return 0;
+               }
+
                pr_debug("thread__find_addr_map failed\n");
                return -1;
        }