mlxsw: spectrum: Mark split ports as such
authorIdo Schimmel <idosch@mellanox.com>
Fri, 16 Dec 2016 18:29:03 +0000 (19:29 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Dec 2016 02:44:51 +0000 (21:44 -0500)
When a port is split we should mark it as such, as otherwise the split
ports aren't renamed correctly (e.g. sw1p3 -> sw1p3s1) and the unsplit
operation fails:

$ devlink port split sw1p3 count 4
$ devlink port unsplit eth0
devlink answers: Invalid argument
[  598.565307] mlxsw_spectrum 0000:03:00.0 eth0: Port wasn't split

Fixes: 67963a33b4fd ("mlxsw: Make devlink port instances independent of spectrum/switchx2 port instances")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reported-by: Tamir Winetroub <tamirw@mellanox.com>
Reviewed-by: Elad Raz <eladr@mellanox.com>
Tested-by: Tamir Winetroub <tamirw@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum.c

index fece974b4edd7fe8f49a98baf75e462b445b6c04..d768c7b6c6d6688c46077c48e25df45cdf9ad7dc 100644 (file)
@@ -2404,7 +2404,7 @@ static int mlxsw_sp_port_create(struct mlxsw_sp *mlxsw_sp, u8 local_port,
                        local_port);
                return err;
        }
-       err = __mlxsw_sp_port_create(mlxsw_sp, local_port, false,
+       err = __mlxsw_sp_port_create(mlxsw_sp, local_port, split,
                                     module, width, lane);
        if (err)
                goto err_port_create;