isdn: hisax: set error code on failure
authorPan Bian <bianpan2016@163.com>
Sun, 4 Dec 2016 10:43:31 +0000 (18:43 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Dec 2016 20:03:42 +0000 (15:03 -0500)
In function hfc4s8s_probe(), the value of return variable err should be
negative on failures. However, when the call to request_region() returns
NULL, the value of err is 0. This patch fixes the bug, assigning
"-EBUSY" to err on the path that request_region() fails.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188931

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/hfc4s8s_l1.c

index 9600cd771f1a3a234a3b7c647904f3dbd22385c7..e034ed847ff32ca1fcf0a55e66eebe2171e3d32f 100644 (file)
@@ -1499,6 +1499,7 @@ hfc4s8s_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                printk(KERN_INFO
                       "HFC-4S/8S: failed to request address space at 0x%04x\n",
                       hw->iobase);
+               err = -EBUSY;
                goto out;
        }