xenbus: don't look up transaction IDs for ordinary writes
authorJan Beulich <JBeulich@suse.com>
Mon, 15 Aug 2016 15:02:38 +0000 (09:02 -0600)
committerDavid Vrabel <david.vrabel@citrix.com>
Wed, 24 Aug 2016 17:16:18 +0000 (18:16 +0100)
This should really only be done for XS_TRANSACTION_END messages, or
else at least some of the xenstore-* tools don't work anymore.

Fixes: 0beef634b8 ("xenbus: don't BUG() on user mode induced condition")
Reported-by: Richard Schütz <rschuetz@uni-koblenz.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Richard Schütz <rschuetz@uni-koblenz.de>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
drivers/xen/xenbus/xenbus_dev_frontend.c

index 7487971f9f788b12a637216c29cc853bb933c1ca..c1010f018bd857985b5bf0ada1f5286f0f68b2bf 100644 (file)
@@ -316,7 +316,7 @@ static int xenbus_write_transaction(unsigned msg_type,
                        rc = -ENOMEM;
                        goto out;
                }
-       } else {
+       } else if (msg_type == XS_TRANSACTION_END) {
                list_for_each_entry(trans, &u->transactions, list)
                        if (trans->handle.id == u->u.msg.tx_id)
                                break;