Resolve TODO comments
authorJoshua Rüsweg <josh@bastelstu.be>
Mon, 6 Aug 2018 09:58:51 +0000 (11:58 +0200)
committerJoshua Rüsweg <josh@bastelstu.be>
Mon, 6 Aug 2018 09:58:51 +0000 (11:58 +0200)
See #2508

wcfsetup/install/files/lib/system/reaction/ReactionHandler.class.php
wcfsetup/install/lang/de.xml
wcfsetup/install/lang/en.xml

index a21caa378cb9b04b129bbc56def4cb11b81f0148..3f2326c6d09293128c811045908f82334989263c 100644 (file)
@@ -337,7 +337,6 @@ class ReactionHandler extends SingletonFactory {
                        WCF::getDB()->rollBackTransaction();
                }
                
-               // @TODO return some dummy values
                return [
                        'cachedReactions' => [], 
                ]; 
@@ -537,7 +536,6 @@ class ReactionHandler extends SingletonFactory {
                        WCF::getDB()->rollBackTransaction();
                }
                
-               // @TODO return some dummy values
                return [
                        'cachedReactions' => [],
                        'reactionTypeID' => null,
index 8b485d90d7578e77b65914ebfba7ec48d959df27..f51ec5ec2eaf3eafaab0cb087a2804dcc3b8ff2f 100644 (file)
                <item name="wcf.acp.menu.link.devtools.notificationTest"><![CDATA[Benachrichtigungstest]]></item>
                <item name="wcf.acp.menu.link.log.modification"><![CDATA[Globales Veränderungsprotokoll]]></item>
                <item name="wcf.acp.menu.link.reactionType"><![CDATA[Reaktionen]]></item>
-               <!-- @TODO maybe use "Reaktion" instead of "Reaktions-Typ", because its more comprehensible for users -->
                <item name="wcf.acp.menu.link.reactionType.list"><![CDATA[Reaktions-Typen]]></item>
                <item name="wcf.acp.menu.link.reactionType.add"><![CDATA[Reaktions-Typ hinzufügen]]></item>
                <item name="wcf.acp.menu.link.reactionType.edit"><![CDATA[Reaktions-Typ bearbeiten]]></item>
index cc86d6683fa42eb6c95a3b8a6c1c5aec8ed26747..6ece2d81dc8c046f97ddcef6748b2e9128822486 100644 (file)
                <item name="wcf.acp.menu.link.devtools.notificationTest"><![CDATA[Notification Test]]></item>
                <item name="wcf.acp.menu.link.log.modification"><![CDATA[Global Modification Log]]></item>
                <item name="wcf.acp.menu.link.reactionType"><![CDATA[Reaction]]></item>
-               <!-- @TODO maybe use "Reactions" instead of "Reaction Types", because its more comprehensible for users -->
                <item name="wcf.acp.menu.link.reactionType.list"><![CDATA[Reaction Types]]></item>
                <item name="wcf.acp.menu.link.reactionType.add"><![CDATA[Add Reaction Type]]></item>
                <item name="wcf.acp.menu.link.reactionType.edit"><![CDATA[Edit Reaction Type]]></item>