Nested tab menus were not preselected on load
authorAlexander Ebert <ebert@woltlab.com>
Thu, 6 Jan 2022 19:20:12 +0000 (20:20 +0100)
committerAlexander Ebert <ebert@woltlab.com>
Thu, 6 Jan 2022 19:20:12 +0000 (20:20 +0100)
See https://www.woltlab.com/community/thread/293819-subtab-direkt-aufrufen-geht-nicht/

ts/WoltLabSuite/Core/Ui/TabMenu/Simple.ts
wcfsetup/install/files/js/WoltLabSuite/Core/Ui/TabMenu/Simple.js

index b2eb37eeb48936db22483a1b3dc2ba29d0e7b4ce..3a287d07fd89eee2a265d414c476a785441a57cc 100644 (file)
@@ -169,9 +169,9 @@ class TabMenuSimple {
 
         // check for parent tab menu
         if (selectTab) {
-          const item = this.container.parentNode as HTMLElement;
-          if (item.classList.contains("tabMenuContainer")) {
-            returnValue = item;
+          const parent = this.container.parentElement;
+          if (parent?.classList.contains("tabMenuContainer")) {
+            returnValue = this.container;
           }
         }
       }
index 1fbe15b98133e723bc2163f7ac3b8707519a9b75..b2369d1f82b49f22fe3bc62a4a1041c7f48dd215 100644 (file)
@@ -140,9 +140,9 @@ define(["require", "exports", "tslib", "../../Core", "../../Dom/Traverse", "../.
                     selectTab = this.tabs.get(hash);
                     // check for parent tab menu
                     if (selectTab) {
-                        const item = this.container.parentNode;
-                        if (item.classList.contains("tabMenuContainer")) {
-                            returnValue = item;
+                        const parent = this.container.parentElement;
+                        if (parent === null || parent === void 0 ? void 0 : parent.classList.contains("tabMenuContainer")) {
+                            returnValue = this.container;
                         }
                     }
                 }