projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: efcf55c)
V4L/DVB (3420): Nskips maybe used uninitialized in bttv_risc_overlay
authorDuncan Sands <baldrick@free.fr>
Thu, 9 Mar 2006 14:20:14 +0000 (11:20 -0300)
committerLinus Torvalds <torvalds@g5.osdl.org>
Tue, 21 Mar 2006 16:52:56 +0000 (08:52 -0800)
The Coverity checker (previously Stanford checker) noticed that
the value of nskips could be read even if it was never written.

Signed-off-by: Duncan Sands <baldrick@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/bttv-risc.c patch | blob | blame | history

diff --git a/drivers/media/video/bttv-risc.c b/drivers/media/video/bttv-risc.c
index a60c211c9e31ba4d667494e77e80bdf9b67a0c4b..5c746110df6295a84f0fa5b830d3e2651c55edc6 100644 (file)
--- a/drivers/media/video/bttv-risc.c
+++ b/drivers/media/video/bttv-risc.c
@@ -276,6 +276,8 @@ bttv_risc_overlay(struct bttv *btv, struct btcx_riscmem *risc,
                if (line > maxy)
                        btcx_calc_skips(line, ov->w.width, &maxy,
                                        skips, &nskips, ov->clips, ov->nclips);
+               else
+                       nskips = 0;
 
                /* write out risc code */
                for (start = 0, skip = 0; start < ov->w.width; start = end) {