projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 7f1a5f0)
char/pcmcia: add some error checking in scr24x_read()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 24 Nov 2016 10:46:23 +0000 (13:46 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Nov 2016 19:43:12 +0000 (20:43 +0100)
The "ret = " assignment seems to have accidentally been left off.

Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/pcmcia/scr24x_cs.c patch | blob | blame | history

diff --git a/drivers/char/pcmcia/scr24x_cs.c b/drivers/char/pcmcia/scr24x_cs.c
index a1de354a89a70a7839bfd8d730b8f3c7b83a8133..f6b43d9350f0f6877ccbc4235df903885390b2a0 100644 (file)
--- a/drivers/char/pcmcia/scr24x_cs.c
+++ b/drivers/char/pcmcia/scr24x_cs.c
@@ -158,7 +158,7 @@ static ssize_t scr24x_read(struct file *filp, char __user *buf, size_t count,
                ret = -EIO;
                goto out;
        }
-       read_chunk(dev, CCID_HEADER_SIZE, len);
+       ret = read_chunk(dev, CCID_HEADER_SIZE, len);
        if (ret < 0)
                goto out;