staging: lustre: lnet: o2iblnd: Use list_for_each_entry_safe

Doubly linked lists which are  iterated  using list_empty
and list_entry macros have been replaced with list_for_each_entry_safe
macro.
This makes the iteration simpler and more readable.

This patch replaces the while loop containing list_empty and list_entry
with list_for_each_entry_safe.

This was done with Coccinelle.

@@
expression E1;
identifier I1, I2;
type T;
iterator name list_for_each_entry_safe;
@@

T *I1;
+ T *tmp;
...
- while (list_empty(&E1) == 0)
+ list_for_each_entry_safe (I1, tmp, &E1, I2)
{
...when != T *I1;
- I1 = list_entry(E1.next, T, I2);
...
}

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c
index 79051c02ab3ac6176cac1dd689a47879bca39df6..2323e8d3a3182e99d75b65fa90d4b0be45daf83b 100644 (file)
--- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c
+++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c
@@ -3157,6 +3157,7 @@ kiblnd_check_conns(int idx)
        struct list_head *ptmp;
        kib_peer_t *peer;
        kib_conn_t *conn;
+       kib_conn_t *temp;
        kib_conn_t *tmp;
        struct list_head *ctmp;
        unsigned long flags;
@@ -3225,8 +3226,7 @@ kiblnd_check_conns(int idx)
         * NOOP, but there were no non-blocking tx descs
         * free to do it last time...
         */
-       while (!list_empty(&checksends)) {
-               conn = list_entry(checksends.next, kib_conn_t, ibc_connd_list);
+       list_for_each_entry_safe(conn, temp, &checksends, ibc_connd_list) {
                list_del(&conn->ibc_connd_list);
                kiblnd_check_sends(conn);
                kiblnd_conn_decref(conn);