ocfs2: one function call less in ocfs2_merge_rec_left() after error detection
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 14 Apr 2015 22:42:51 +0000 (15:42 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 14 Apr 2015 23:48:57 +0000 (16:48 -0700)
ocfs2_free_path() was called by ocfs2_merge_rec_left() even if a call of
the ocfs2_get_left_path() function failed.

Return from this implementation directly after corresponding
exception handling.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ocfs2/alloc.c

index 370b4ea4c23a3eab66d8399992c2e5cf80ecf0be..4bdc19fb7b854f6021d7a4b07a493607c888cdd6 100644 (file)
@@ -3535,7 +3535,7 @@ static int ocfs2_merge_rec_left(struct ocfs2_path *right_path,
                ret = ocfs2_get_left_path(et, right_path, &left_path);
                if (ret) {
                        mlog_errno(ret);
-                       goto out;
+                       return ret;
                }
 
                left_el = path_leaf_el(left_path);