carl9170: Fix memory accounting when sta is in power-save mode.
authorNicolas Cavallari <Nicolas.Cavallari@lri.fr>
Thu, 23 Feb 2012 15:53:34 +0000 (16:53 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 29 Feb 2012 18:08:51 +0000 (13:08 -0500)
On Access Point mode, when transmitting a packet, if the destination
station is in powersave mode, we abort transmitting the packet to the
device queue, but we do not reclaim the allocated memory.  Given enough
packets, we can go in a state where there is no packet on the device
queue, but we think the device has no memory left, so no packet gets
transmitted, connections breaks and the AP stops working.

This undo the allocation done in the TX path when the station is in
power-save mode.

Signed-off-by: Nicolas Cavallari <cavallar@lri.fr>
Acked-by: Christian Lamparter <chunkeey@googlemail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/carl9170/tx.c

index d19a9ee9d057a904577d9497435911bc2867e978..22a793121bd3b48a4a70f5625fc46c1c646ec1d3 100644 (file)
@@ -1251,6 +1251,7 @@ static bool carl9170_tx_ps_drop(struct ar9170 *ar, struct sk_buff *skb)
                        atomic_dec(&ar->tx_ampdu_upload);
 
                tx_info->flags |= IEEE80211_TX_STAT_TX_FILTERED;
+               carl9170_release_dev_space(ar, skb);
                carl9170_tx_status(ar, skb, false);
                return true;
        }