bgmac: Fix reversed test of build_skb() return value.
authorDavid S. Miller <davem@davemloft.net>
Fri, 15 Jan 2016 21:07:13 +0000 (16:07 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jul 2017 12:37:18 +0000 (14:37 +0200)
commit 750afbf8ee9c6a1c74a1fe5fc9852146b1d72687 upstream.

Fixes: f1640c3ddeec ("bgmac: fix a missing check for build_skb")
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/bgmac.c

index b7e10e1b91312feae39503658f33721d829fb356..20356755b708ad68ec800c63883bdcaf36d3faaf 100644 (file)
@@ -469,7 +469,7 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
                        len -= ETH_FCS_LEN;
 
                        skb = build_skb(buf, BGMAC_RX_ALLOC_SIZE);
-                       if (unlikely(skb)) {
+                       if (unlikely(!skb)) {
                                bgmac_err(bgmac, "build_skb failed\n");
                                put_page(virt_to_head_page(buf));
                                break;