PCI: dra7xx: Fix return value in case of error
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 14 Jul 2016 21:18:27 +0000 (23:18 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 25 Jul 2016 17:29:51 +0000 (12:29 -0500)
In dra7xx_pcie_init_irq_domain(), the pattern used to check and return
error is:

   if (!var) {
      dev_err(...);
      return PTR_ERR(var);
   }

So the returned value in case of error is always 0, which means 'success'.
Change it to return -ENODEV instead.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/pci/host/pci-dra7xx.c

index f441130407e77d2e33c645a42c9972c69a3d0462..81b3949a26dbda1ed9586ba2cefbe7450f5e7f02 100644 (file)
@@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
 
        if (!pcie_intc_node) {
                dev_err(dev, "No PCIe Intc node found\n");
-               return PTR_ERR(pcie_intc_node);
+               return -ENODEV;
        }
 
        pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
                                               &intx_domain_ops, pp);
        if (!pp->irq_domain) {
                dev_err(dev, "Failed to get a INTx IRQ domain\n");
-               return PTR_ERR(pp->irq_domain);
+               return -ENODEV;
        }
 
        return 0;