ACPI video: add a warning message if _BQC is not found
authorZhang Rui <rui.zhang@intel.com>
Thu, 12 Mar 2009 08:57:11 +0000 (16:57 +0800)
committerLen Brown <len.brown@intel.com>
Sat, 28 Mar 2009 02:37:22 +0000 (22:37 -0400)
ACPI backlight control w/o _BQC support is kinda firmware bug.
Add a warning if _BQC is not implemented.

Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/video_detect.c

index 50e3d2dbf3af8dcb4dca0e280f0a7efa891d0738..09737275e25fd94990d7e250f7acfcc09d2e10af 100644 (file)
@@ -55,6 +55,9 @@ acpi_backlight_cap_match(acpi_handle handle, u32 level, void *context,
                ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Found generic backlight "
                                  "support\n"));
                *cap |= ACPI_VIDEO_BACKLIGHT;
+               if (ACPI_FAILURE(acpi_get_handle(handle, "_BQC", &h_dummy)))
+                       printk(KERN_WARNING FW_BUG PREFIX "ACPI brightness "
+                                       "control misses _BQC function\n");
                /* We have backlight support, no need to scan further */
                return AE_CTRL_TERMINATE;
        }