[PATCH] Fix the kernel panic of audit_filter_task when key field is set
authorzhangxiliang <zhangxiliang@cn.fujitsu.com>
Fri, 1 Aug 2008 11:15:47 +0000 (19:15 +0800)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 1 Aug 2008 16:15:03 +0000 (12:15 -0400)
When calling audit_filter_task(), it calls audit_filter_rules() with audit_context is NULL.
If the key field is set, the result in audit_filter_rules() will be set to 1 and
ctx->filterkey will be set to key.
But the ctx is NULL in this condition, so kernel will panic.

Signed-off-by: Zhang Xiliang <zhangxiliang@cn.fujitsu.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
kernel/auditsc.c

index 580a5389fd99beff21f8972d63657b54ba326cb8..496c3dd372761a4862791658d7635db3fca87e65 100644 (file)
@@ -610,7 +610,7 @@ static int audit_filter_rules(struct task_struct *tsk,
                if (!result)
                        return 0;
        }
-       if (rule->filterkey)
+       if (rule->filterkey && ctx)
                ctx->filterkey = kstrdup(rule->filterkey, GFP_ATOMIC);
        switch (rule->action) {
        case AUDIT_NEVER:    *state = AUDIT_DISABLED;       break;