microblaze/timer: Migrate to new 'set-state' interface
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 16 Jul 2015 11:26:21 +0000 (16:56 +0530)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 10 Aug 2015 09:41:00 +0000 (11:41 +0200)
Migrate microblaze driver to the new 'set-state' interface provided by
clockevents core, the earlier 'set-mode' interface is marked obsolete
now.

This also enables us to implement callbacks for new states of clockevent
devices, for example: ONESHOT_STOPPED.

We weren't doing anything in ->set_mode(RESUME or ONESHOT) and so
tick_resume() set_state_oneshot() aren't implemented.

Cc: Michal Simek <monstr@monstr.eu>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
arch/microblaze/kernel/timer.c

index c8977450e28c9565b39d1a866de370554a369a79..67e2ef48d2d0156fc9a4ab3c62e46867a43a04a5 100644 (file)
@@ -122,37 +122,29 @@ static int xilinx_timer_set_next_event(unsigned long delta,
        return 0;
 }
 
-static void xilinx_timer_set_mode(enum clock_event_mode mode,
-                               struct clock_event_device *evt)
+static int xilinx_timer_shutdown(struct clock_event_device *evt)
 {
-       switch (mode) {
-       case CLOCK_EVT_MODE_PERIODIC:
-               pr_info("%s: periodic\n", __func__);
-               xilinx_timer0_start_periodic(freq_div_hz);
-               break;
-       case CLOCK_EVT_MODE_ONESHOT:
-               pr_info("%s: oneshot\n", __func__);
-               break;
-       case CLOCK_EVT_MODE_UNUSED:
-               pr_info("%s: unused\n", __func__);
-               break;
-       case CLOCK_EVT_MODE_SHUTDOWN:
-               pr_info("%s: shutdown\n", __func__);
-               xilinx_timer0_stop();
-               break;
-       case CLOCK_EVT_MODE_RESUME:
-               pr_info("%s: resume\n", __func__);
-               break;
-       }
+       pr_info("%s\n", __func__);
+       xilinx_timer0_stop();
+       return 0;
+}
+
+static int xilinx_timer_set_periodic(struct clock_event_device *evt)
+{
+       pr_info("%s\n", __func__);
+       xilinx_timer0_start_periodic(freq_div_hz);
+       return 0;
 }
 
 static struct clock_event_device clockevent_xilinx_timer = {
-       .name           = "xilinx_clockevent",
-       .features       = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC,
-       .shift          = 8,
-       .rating         = 300,
-       .set_next_event = xilinx_timer_set_next_event,
-       .set_mode       = xilinx_timer_set_mode,
+       .name                   = "xilinx_clockevent",
+       .features               = CLOCK_EVT_FEAT_ONESHOT |
+                                 CLOCK_EVT_FEAT_PERIODIC,
+       .shift                  = 8,
+       .rating                 = 300,
+       .set_next_event         = xilinx_timer_set_next_event,
+       .set_state_shutdown     = xilinx_timer_shutdown,
+       .set_state_periodic     = xilinx_timer_set_periodic,
 };
 
 static inline void timer_ack(void)