ocfs2/xattr: Only extend xattr bucket in need.
authorTao Ma <tao.ma@oracle.com>
Wed, 12 Nov 2008 00:26:57 +0000 (08:26 +0800)
committerMark Fasheh <mfasheh@suse.com>
Mon, 5 Jan 2009 16:34:18 +0000 (08:34 -0800)
When the first block of a bucket is filled up with xattr
entries, we normally extend the bucket. But if we are
just replace one xattr with small length, we don't need
to extend it. This is important since we will calculate
what we need before the transaction and in this situation
no resources will be allocated.

Signed-off-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
fs/ocfs2/xattr.c

index d8fc714e941576be4484e385c65212d6f6f05521..4501c63193df0b04152e3a71c72ebce7e5874372 100644 (file)
@@ -4564,7 +4564,9 @@ try_again:
             free, need, max_free, le16_to_cpu(xh->xh_free_start),
             le16_to_cpu(xh->xh_name_value_len));
 
-       if (free < need || count == ocfs2_xattr_max_xe_in_bucket(inode->i_sb)) {
+       if (free < need ||
+           (xs->not_found &&
+            count == ocfs2_xattr_max_xe_in_bucket(inode->i_sb))) {
                if (need <= max_free &&
                    count < ocfs2_xattr_max_xe_in_bucket(inode->i_sb)) {
                        /*