ext2: remove ext2_aops_xip
authorMatthew Wilcox <matthew.r.wilcox@intel.com>
Mon, 16 Feb 2015 23:59:28 +0000 (15:59 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 17 Feb 2015 01:56:04 +0000 (17:56 -0800)
We shouldn't need a special address_space_operations any more

Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Boaz Harrosh <boaz@plexistor.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ext2/ext2.h
fs/ext2/inode.c
fs/ext2/namei.c

index 6854038c09ae2953df605fcb3f599ad406bfddbe..ab9b3ec3bac9637c104eb140c0b179d1ed26cc5a 100644 (file)
@@ -796,7 +796,6 @@ extern const struct file_operations ext2_xip_file_operations;
 
 /* inode.c */
 extern const struct address_space_operations ext2_aops;
-extern const struct address_space_operations ext2_aops_xip;
 extern const struct address_space_operations ext2_nobh_aops;
 
 /* namei.c */
index 154cbcf30f3561d971fe983fba38666bc24b1afc..034fd42eade0684f089558b77d2363e949c081db 100644 (file)
@@ -891,11 +891,6 @@ const struct address_space_operations ext2_aops = {
        .error_remove_page      = generic_error_remove_page,
 };
 
-const struct address_space_operations ext2_aops_xip = {
-       .bmap                   = ext2_bmap,
-       .direct_IO              = ext2_direct_IO,
-};
-
 const struct address_space_operations ext2_nobh_aops = {
        .readpage               = ext2_readpage,
        .readpages              = ext2_readpages,
@@ -1394,7 +1389,7 @@ struct inode *ext2_iget (struct super_block *sb, unsigned long ino)
        if (S_ISREG(inode->i_mode)) {
                inode->i_op = &ext2_file_inode_operations;
                if (test_opt(inode->i_sb, XIP)) {
-                       inode->i_mapping->a_ops = &ext2_aops_xip;
+                       inode->i_mapping->a_ops = &ext2_aops;
                        inode->i_fop = &ext2_xip_file_operations;
                } else if (test_opt(inode->i_sb, NOBH)) {
                        inode->i_mapping->a_ops = &ext2_nobh_aops;
index 7ca803f408b07c42b48acab8df4cffd7a0f34230..0db888c91becfa2549342120f8b9b5f2d7698c2f 100644 (file)
@@ -105,7 +105,7 @@ static int ext2_create (struct inode * dir, struct dentry * dentry, umode_t mode
 
        inode->i_op = &ext2_file_inode_operations;
        if (test_opt(inode->i_sb, XIP)) {
-               inode->i_mapping->a_ops = &ext2_aops_xip;
+               inode->i_mapping->a_ops = &ext2_aops;
                inode->i_fop = &ext2_xip_file_operations;
        } else if (test_opt(inode->i_sb, NOBH)) {
                inode->i_mapping->a_ops = &ext2_nobh_aops;
@@ -126,7 +126,7 @@ static int ext2_tmpfile(struct inode *dir, struct dentry *dentry, umode_t mode)
 
        inode->i_op = &ext2_file_inode_operations;
        if (test_opt(inode->i_sb, XIP)) {
-               inode->i_mapping->a_ops = &ext2_aops_xip;
+               inode->i_mapping->a_ops = &ext2_aops;
                inode->i_fop = &ext2_xip_file_operations;
        } else if (test_opt(inode->i_sb, NOBH)) {
                inode->i_mapping->a_ops = &ext2_nobh_aops;