dm ioctl: remove double parentheses
authorMatthias Kaehlcke <mka@chromium.org>
Mon, 17 Apr 2017 18:05:03 +0000 (11:05 -0700)
committerMichael Benedict <michaelbt@live.com>
Sat, 31 Aug 2019 16:28:16 +0000 (02:28 +1000)
commit e36215d87f301f9567c8c99fd34e6c3521a94ddf upstream.

The extra pair of parantheses is not needed and causes clang to generate
warnings about the DM_DEV_CREATE_CMD comparison in validate_params().

Also remove another double parentheses that doesn't cause a warning.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/dm-ioctl.c

index 7baeeafa059db7c2242f7b08c9d3a4ce3eca00d7..065d7cee0d219b9690fe62569e9bc6c134c87ed7 100644 (file)
@@ -1773,12 +1773,12 @@ static int validate_params(uint cmd, struct dm_ioctl *param)
            cmd == DM_LIST_VERSIONS_CMD)
                return 0;
 
-       if ((cmd == DM_DEV_CREATE_CMD)) {
+       if (cmd == DM_DEV_CREATE_CMD) {
                if (!*param->name) {
                        DMWARN("name not supplied when creating device");
                        return -EINVAL;
                }
-       } else if ((*param->uuid && *param->name)) {
+       } else if (*param->uuid && *param->name) {
                DMWARN("only supply one of name or uuid, cmd(%u)", cmd);
                return -EINVAL;
        }