isp1362-hcd: don't reimplement proc_create_data()
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 30 Mar 2013 17:15:27 +0000 (13:15 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 9 Apr 2013 18:13:10 +0000 (14:13 -0400)
... especially in a racy way

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/usb/host/isp1362-hcd.c

index 974480c516fabc956f200f2c42941f281d792238..9137caadb1c86e913ce2c3595fb0b5c007d20a1c 100644 (file)
@@ -2192,14 +2192,11 @@ static void create_debug_file(struct isp1362_hcd *isp1362_hcd)
 {
        struct proc_dir_entry *pde;
 
-       pde = create_proc_entry(proc_filename, 0, NULL);
+       pde = proc_create_data(proc_filename, 0, NULL, &proc_ops, isp1362_hcd);
        if (pde == NULL) {
                pr_warning("%s: Failed to create debug file '%s'\n", __func__, proc_filename);
                return;
        }
-
-       pde->proc_fops = &proc_ops;
-       pde->data = isp1362_hcd;
        isp1362_hcd->pde = pde;
 }