ASoC: Remove codec field from snd_soc_dapm_widget
authorLars-Peter Clausen <lars@metafoo.de>
Thu, 15 Jan 2015 11:52:17 +0000 (12:52 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 15 Jan 2015 11:57:34 +0000 (11:57 +0000)
There are no more users of this field left so it can finally be removed.
New users should use snd_soc_dapm_to_codec(w->dapm);

The reason why it is removed is because it doesn't fit to well anymore in
the componentized ASoC hierarchy, where DAPM works on the snd_soc_component
level. And the alternative of snd_soc_dapm_to_codec(w->dapm) typically
generates the same amount of code, so there is really no reason to keep it.

For automatic conversion the following coccinelle semantic patch can be used:
// <smpl>
@@
struct snd_soc_dapm_widget *w;
@@
-w->codec
+snd_soc_dapm_to_codec(w->dapm)
// </smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/soc-dapm.h
sound/soc/soc-dapm.c

index 89823cfe6f043147b3798b78ac4034831d25c790..cc7104ab966019202fb65a7c5decd4472256c5b3 100644 (file)
@@ -526,7 +526,6 @@ struct snd_soc_dapm_widget {
        enum snd_soc_dapm_type id;
        const char *name;               /* widget name */
        const char *sname;      /* stream name */
-       struct snd_soc_codec *codec;
        struct list_head list;
        struct snd_soc_dapm_context *dapm;
 
index c5136bb1f9821afe43bae8a2f9bece210e699952..f6ae254e33ef968762a639bd1de81e8e5d8e2c99 100644 (file)
@@ -3130,8 +3130,6 @@ snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm,
        }
 
        w->dapm = dapm;
-       if (dapm->component)
-               w->codec = dapm->component->codec;
        INIT_LIST_HEAD(&w->sources);
        INIT_LIST_HEAD(&w->sinks);
        INIT_LIST_HEAD(&w->list);