greybus: connection: rename connection-create interface
authorJohan Hovold <johan@hovoldconsulting.com>
Thu, 21 Jan 2016 16:34:15 +0000 (17:34 +0100)
committerGreg Kroah-Hartman <gregkh@google.com>
Fri, 22 Jan 2016 06:45:09 +0000 (22:45 -0800)
Drop the _dynamic suffix from the exported interface that drivers use to
create connections.

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/connection.c
drivers/staging/greybus/connection.h
drivers/staging/greybus/legacy.c

index 227bfe8ba34122780d17e15a6c1df64954a6103a..5d0edbe7e7499fb30841a927f64cdd7d1d4974dd 100644 (file)
@@ -112,7 +112,7 @@ static void gb_connection_init_name(struct gb_connection *connection)
 }
 
 /*
- * gb_connection_create() - create a Greybus connection
+ * _gb_connection_create() - create a Greybus connection
  * @hd:                        host device of the connection
  * @hd_cport_id:       host-device cport id, or -1 for dynamic allocation
  * @intf:              remote interface, or NULL for static connections
@@ -132,7 +132,7 @@ static void gb_connection_init_name(struct gb_connection *connection)
  * Return: A pointer to the new connection if successful, or NULL otherwise.
  */
 static struct gb_connection *
-gb_connection_create(struct gb_host_device *hd, int hd_cport_id,
+_gb_connection_create(struct gb_host_device *hd, int hd_cport_id,
                                struct gb_interface *intf,
                                struct gb_bundle *bundle, int cport_id)
 {
@@ -215,23 +215,23 @@ err_unlock:
 struct gb_connection *
 gb_connection_create_static(struct gb_host_device *hd, u16 hd_cport_id)
 {
-       return gb_connection_create(hd, hd_cport_id, NULL, NULL, 0);
+       return _gb_connection_create(hd, hd_cport_id, NULL, NULL, 0);
 }
 
 struct gb_connection *
 gb_connection_create_control(struct gb_interface *intf)
 {
-       return gb_connection_create(intf->hd, -1, intf, NULL, 0);
+       return _gb_connection_create(intf->hd, -1, intf, NULL, 0);
 }
 
 struct gb_connection *
-gb_connection_create_dynamic(struct gb_bundle *bundle, u16 cport_id)
+gb_connection_create(struct gb_bundle *bundle, u16 cport_id)
 {
        struct gb_interface *intf = bundle->intf;
 
-       return gb_connection_create(intf->hd, -1, intf, bundle, cport_id);
+       return _gb_connection_create(intf->hd, -1, intf, bundle, cport_id);
 }
-EXPORT_SYMBOL_GPL(gb_connection_create_dynamic);
+EXPORT_SYMBOL_GPL(gb_connection_create);
 
 static int gb_connection_hd_cport_enable(struct gb_connection *connection)
 {
index 863109cb4180b83cad9e667299ed9510f80cc8ad..0e78f10d91c8996257455e167956056ba64f48c4 100644 (file)
@@ -58,7 +58,7 @@ struct gb_connection {
 struct gb_connection *gb_connection_create_static(struct gb_host_device *hd,
                                u16 hd_cport_id);
 struct gb_connection *gb_connection_create_control(struct gb_interface *intf);
-struct gb_connection *gb_connection_create_dynamic(struct gb_bundle *bundle,
+struct gb_connection *gb_connection_create(struct gb_bundle *bundle,
                                u16 cport_id);
 void gb_connection_destroy(struct gb_connection *connection);
 
index 86ab7b7141ec389590c980c6c7d47cf4594da713..fb0a82edcfb14984b189efd6cfd004edd2a00c4d 100644 (file)
@@ -153,7 +153,7 @@ static int legacy_probe(struct gb_bundle *bundle,
        for (i = 0; i < data->num_cports; ++i) {
                cport_desc = &bundle->cport_desc[i];
 
-               connection = gb_connection_create_dynamic(bundle,
+               connection = gb_connection_create(bundle,
                                                le16_to_cpu(cport_desc->id));
                if (!connection)
                        goto err_connections_destroy;