dm ioctl: fix error return code in target_message
authorQinglang Miao <miaoqinglang@huawei.com>
Sat, 28 Nov 2020 10:19:59 +0000 (18:19 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Dec 2020 12:46:58 +0000 (13:46 +0100)
[ Upstream commit 4d7659bfbe277a43399a4a2d90fca141e70f29e1 ]

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 2ca4c92f58f9 ("dm ioctl: prevent empty message")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/md/dm-ioctl.c

index ca948155191ac08a78df6b3a78d55dffdcf7a317..469453e106d1464065f7ee7f3edb290fb068ea8c 100644 (file)
@@ -1574,6 +1574,7 @@ static int target_message(struct file *filp, struct dm_ioctl *param, size_t para
 
        if (!argc) {
                DMWARN("Empty message received.");
+               r = -EINVAL;
                goto out_argv;
        }