[PATCH] libata: make ata_bus_probe() return negative errno on failure
authorTejun Heo <htejun@gmail.com>
Fri, 31 Mar 2006 16:38:17 +0000 (01:38 +0900)
committerJeff Garzik <jeff@garzik.org>
Sat, 1 Apr 2006 17:33:45 +0000 (12:33 -0500)
ata_bus_probe() uses unsigned int rc to receive negative errno and
returns the converted unsigned int value.  Convert temporary variables
to int and make ata_bus_probe() return negative errno on failure.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/scsi/libata-core.c

index 8def7a5e436a86a8f58f7765fdf99d99201e3a2f..c7ba523fb1eb9d23fb3c77e153ccb51f707a26a8 100644 (file)
@@ -1349,13 +1349,13 @@ err_out_nosup:
  *     PCI/etc. bus probe sem.
  *
  *     RETURNS:
- *     Zero on success, non-zero on error.
+ *     Zero on success, negative errno otherwise.
  */
 
 static int ata_bus_probe(struct ata_port *ap)
 {
        unsigned int classes[ATA_MAX_DEVICES];
-       unsigned int i, rc, found = 0;
+       int i, rc, found = 0;
 
        ata_port_probe(ap);
 
@@ -1421,7 +1421,7 @@ static int ata_bus_probe(struct ata_port *ap)
 
 err_out_disable:
        ap->ops->port_disable(ap);
-       return -1;
+       return -ENODEV;
 }
 
 /**