KVM: remove superfluous NULL pointer check in kvm_inject_pit_timer_irqs()
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Tue, 28 Jul 2009 22:46:38 +0000 (00:46 +0200)
committerAvi Kivity <avi@redhat.com>
Thu, 10 Sep 2009 05:33:19 +0000 (08:33 +0300)
This takes care of the following entries from Dan's list:

arch/x86/kvm/i8254.c +714 kvm_inject_pit_timer_irqs(6) warning: variable derefenced in initializer 'vcpu'
arch/x86/kvm/i8254.c +714 kvm_inject_pit_timer_irqs(6) warning: variable derefenced before check 'vcpu'

Reported-by: Dan Carpenter <error27@gmail.com>
Cc: corbet@lwn.net
Cc: eteo@redhat.com
Cc: Julia Lawall <julia@diku.dk>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sheng Yang <sheng@linux.intel.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/i8254.c

index 472653c15a2a656eab70ab0d65e13ebad42c6c5d..82ad523b490187c4d2f9cea90228293f868c8496 100644 (file)
@@ -713,7 +713,7 @@ void kvm_inject_pit_timer_irqs(struct kvm_vcpu *vcpu)
        struct kvm *kvm = vcpu->kvm;
        struct kvm_kpit_state *ps;
 
-       if (vcpu && pit) {
+       if (pit) {
                int inject = 0;
                ps = &pit->pit_state;