drm/i915: make system freeze support depend on CONFIG_ACPI_SLEEP
authorImre Deak <imre.deak@intel.com>
Mon, 23 Jun 2014 12:46:02 +0000 (15:46 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 8 Jul 2014 10:30:15 +0000 (12:30 +0200)
To achieve further power savings during system freeze (aka connected
standby, or s0ix) we have to send a PCI_D1 opregion notification. As
the information about the state we're entering (system freeze,
suspend to ram or suspend to disk) is only available through the ACPI
subsystem, make this support depend on the relevant kconfig option.
Things will still work if this option isn't set, albeit with less than
optimial power saving.

This also fixes a compile breakage when the option is not set introduced
in

commit e5747e3adcd67ae27105003ec99fb58cba180105
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Jun 12 08:35:47 2014 -0700

    drm/i915: send proper opregion notifications on suspend/resume

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.c

index bc1962362ffbd160cdb873b2db8385473c1a1564..23139aaa9431ca10d3c88fad5851ee09df2c23de 100644 (file)
@@ -540,10 +540,11 @@ static int i915_drm_freeze(struct drm_device *dev)
 
        i915_save_state(dev);
 
-       if (acpi_target_system_state() >= ACPI_STATE_S3)
-               opregion_target_state = PCI_D3cold;
-       else
+       opregion_target_state = PCI_D3cold;
+#if IS_ENABLED(CONFIG_ACPI_SLEEP)
+       if (acpi_target_system_state() < ACPI_STATE_S3)
                opregion_target_state = PCI_D1;
+#endif
        intel_opregion_notify_adapter(dev, opregion_target_state);
 
        intel_uncore_forcewake_reset(dev, false);