enic: Fix 64 bit divide on 32bit system
authorGovindarajulu Varadarajan <_govind@gmx.com>
Mon, 26 May 2014 10:22:43 +0000 (15:52 +0530)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 May 2014 22:54:46 +0000 (15:54 -0700)
Division of a 32 bit number by a 64 bit number causes the following link
error introduced by
7c2ce6e60f703 "enic: Add support for adaptive interrupt coalescing"

drivers/built-in.o: In function `enic_poll_msix':
enic_main.c:(.text+0x48710a): undefined reference to `__udivdi3'
make: *** [vmlinux] Error 1

Since numerator is 32 bit, convert denominator to 32 bit accordingly.

Fixes: 7c2ce6e60f703 ("enic: Add support for adaptive interrupt coalescing")
Reported-by: Jim Davis <jim.epost@gmail.com>
Cc: Christian Benvenuti <benve@cisco.com>
Cc: Sujith Sankar <ssujith@cisco.com>
Cc: Neel Patel <neepatel@cisco.com>
Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cisco/enic/enic_main.c

index 0d8995cc92ed65902e245eb40d665091c968e8cc..d5a220d5bad1e811cd2e2afd8b70708fd34c2b50 100644 (file)
@@ -1217,7 +1217,7 @@ static void enic_calc_int_moderation(struct enic *enic, struct vnic_rq *rq)
         */
 
        traffic <<= 3;
-       traffic /= delta;
+       traffic = delta > UINT_MAX ? 0 : traffic / (u32)delta;
 
        for (index = 0; index < ENIC_MAX_COALESCE_TIMERS; index++)
                if (traffic < mod_table[index].rx_rate)