KVM: MIPS: Implement HYPCALL emulation

Emulate the HYPCALL instruction added in the VZ ASE and used by the MIPS
paravirtualised guest support that is already merged. The new hypcall.c
handles arguments and the return value. No actual hypercalls are yet
supported, but this still allows us to safely step over hypercalls and
set an error code in the return value for forward compatibility.

Non-zero HYPCALL codes are not handled.

We also document the hypercall ABI which asm/kvm_para.h uses.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
Cc: David Daney <david.daney@cavium.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-mips@linux-mips.org
Cc: kvm@vger.kernel.org
Cc: linux-doc@vger.kernel.org

diff --git a/Documentation/virtual/kvm/hypercalls.txt b/Documentation/virtual/kvm/hypercalls.txt
index feaaa634f154bb44d400758f82adcc3f1a6c85da..a890529c63ed6a3be4e2c38eb739377b37c6bc4c 100644 (file)
--- a/Documentation/virtual/kvm/hypercalls.txt
+++ b/Documentation/virtual/kvm/hypercalls.txt
@@ -28,6 +28,11 @@ S390:
   property inside the device tree's /hypervisor node.
   For more information refer to Documentation/virtual/kvm/ppc-pv.txt
 
+MIPS:
+  KVM hypercalls use the HYPCALL instruction with code 0 and the hypercall
+  number in $2 (v0). Up to four arguments may be placed in $4-$7 (a0-a3) and
+  the return value is placed in $2 (v0).
+
 KVM Hypercalls Documentation
 ===========================
 The template for each hypercall is:

diff --git a/arch/mips/include/asm/kvm_host.h b/arch/mips/include/asm/kvm_host.h
index 05e785fc061daa4b8b25ce054a8d5924d811554c..0d308d4f2429f9abe299c09b0712167e508b4ef2 100644 (file)
--- a/arch/mips/include/asm/kvm_host.h
+++ b/arch/mips/include/asm/kvm_host.h
@@ -229,6 +229,7 @@ enum emulation_result {
        EMULATE_WAIT,           /* WAIT instruction */
        EMULATE_PRIV_FAIL,
        EMULATE_EXCEPT,         /* A guest exception has been generated */
+       EMULATE_HYPERCALL,      /* HYPCALL instruction */
 };
 
 #define mips3_paddr_to_tlbpfn(x) \
@@ -832,6 +833,12 @@ unsigned int kvm_mips_config3_wrmask(struct kvm_vcpu *vcpu);
 unsigned int kvm_mips_config4_wrmask(struct kvm_vcpu *vcpu);
 unsigned int kvm_mips_config5_wrmask(struct kvm_vcpu *vcpu);
 
+/* Hypercalls (hypcall.c) */
+
+enum emulation_result kvm_mips_emul_hypcall(struct kvm_vcpu *vcpu,
+                                           union mips_instruction inst);
+int kvm_mips_handle_hypcall(struct kvm_vcpu *vcpu);
+
 /* Dynamic binary translation */
 extern int kvm_mips_trans_cache_index(union mips_instruction inst,
                                      u32 *opc, struct kvm_vcpu *vcpu);

diff --git a/arch/mips/include/uapi/asm/inst.h b/arch/mips/include/uapi/asm/inst.h
index 77429d1622b343aed9f6a0d1c81f5ed4eacadffd..b5e46ae872d3b55214f16e1249a13a86387c7aca 100644 (file)
--- a/arch/mips/include/uapi/asm/inst.h
+++ b/arch/mips/include/uapi/asm/inst.h
@@ -179,7 +179,7 @@ enum cop0_coi_func {
        tlbr_op       = 0x01, tlbwi_op      = 0x02,
        tlbwr_op      = 0x06, tlbp_op       = 0x08,
        rfe_op        = 0x10, eret_op       = 0x18,
-       wait_op       = 0x20,
+       wait_op       = 0x20, hypcall_op    = 0x28
 };
 
 /*

diff --git a/arch/mips/kvm/Makefile b/arch/mips/kvm/Makefile
index 847429de780d3b948fe9cb296e40223188af715e..e56403c8a3f5f9b64cfe8e051f2d33224b23f255 100644 (file)
--- a/arch/mips/kvm/Makefile
+++ b/arch/mips/kvm/Makefile
@@ -10,6 +10,7 @@ common-objs-$(CONFIG_CPU_HAS_MSA) += msa.o
 kvm-objs := $(common-objs-y) mips.o emulate.o entry.o \
            interrupt.o stats.o commpage.o \
            dyntrans.o trap_emul.o fpu.o
+kvm-objs += hypcall.o
 kvm-objs += mmu.o
 
 obj-$(CONFIG_KVM)      += kvm.o

diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
index d40cfaad45295c8631f306a96fbb0d713e2a864a..637753ea0a00e7af539722ed8e79aa8c01700b23 100644 (file)
--- a/arch/mips/kvm/emulate.c
+++ b/arch/mips/kvm/emulate.c
@@ -1143,6 +1143,9 @@ enum emulation_result kvm_mips_emulate_CP0(union mips_instruction inst,
                case wait_op:
                        er = kvm_mips_emul_wait(vcpu);
                        break;
+               case hypcall_op:
+                       er = kvm_mips_emul_hypcall(vcpu, inst);
+                       break;
                }
        } else {
                rt = inst.c0r_format.rt;

diff --git a/arch/mips/kvm/hypcall.c b/arch/mips/kvm/hypcall.c
new file mode 100644 (file)
index 0000000..8306343
--- /dev/null
+++ b/arch/mips/kvm/hypcall.c
@@ -0,0 +1,53 @@
+/*
+ * This file is subject to the terms and conditions of the GNU General Public
+ * License.  See the file "COPYING" in the main directory of this archive
+ * for more details.
+ *
+ * KVM/MIPS: Hypercall handling.
+ *
+ * Copyright (C) 2015  Imagination Technologies Ltd.
+ */
+
+#include <linux/kernel.h>
+#include <linux/kvm_host.h>
+#include <linux/kvm_para.h>
+
+#define MAX_HYPCALL_ARGS       4
+
+enum emulation_result kvm_mips_emul_hypcall(struct kvm_vcpu *vcpu,
+                                           union mips_instruction inst)
+{
+       unsigned int code = (inst.co_format.code >> 5) & 0x3ff;
+
+       kvm_debug("[%#lx] HYPCALL %#03x\n", vcpu->arch.pc, code);
+
+       switch (code) {
+       case 0:
+               return EMULATE_HYPERCALL;
+       default:
+               return EMULATE_FAIL;
+       };
+}
+
+static int kvm_mips_hypercall(struct kvm_vcpu *vcpu, unsigned long num,
+                             const unsigned long *args, unsigned long *hret)
+{
+       /* Report unimplemented hypercall to guest */
+       *hret = -KVM_ENOSYS;
+       return RESUME_GUEST;
+}
+
+int kvm_mips_handle_hypcall(struct kvm_vcpu *vcpu)
+{
+       unsigned long num, args[MAX_HYPCALL_ARGS];
+
+       /* read hypcall number and arguments */
+       num = vcpu->arch.gprs[2];       /* v0 */
+       args[0] = vcpu->arch.gprs[4];   /* a0 */
+       args[1] = vcpu->arch.gprs[5];   /* a1 */
+       args[2] = vcpu->arch.gprs[6];   /* a2 */
+       args[3] = vcpu->arch.gprs[7];   /* a3 */
+
+       return kvm_mips_hypercall(vcpu, num,
+                                 args, &vcpu->arch.gprs[2] /* v0 */);
+}

diff --git a/arch/mips/kvm/trap_emul.c b/arch/mips/kvm/trap_emul.c
index b1fa53b252eab2e94a93ef24c6a9183abff0d37e..3a854bb9e606be2a3661273b477ddb75bd408976 100644 (file)
--- a/arch/mips/kvm/trap_emul.c
+++ b/arch/mips/kvm/trap_emul.c
@@ -82,6 +82,10 @@ static int kvm_trap_emul_handle_cop_unusable(struct kvm_vcpu *vcpu)
                ret = RESUME_HOST;
                break;
 
+       case EMULATE_HYPERCALL:
+               ret = kvm_mips_handle_hypcall(vcpu);
+               break;
+
        default:
                BUG();
        }