regulator: pv88080: Fix array out-of-bounds access
authorAxel Lin <axel.lin@ingics.com>
Tue, 19 Feb 2019 10:00:01 +0000 (18:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:16 +0000 (10:24 +0100)
[ Upstream commit 3c413f594c4f9df40061445667ca11a12bc8ee34 ]

Fix off-by-one while iterating current_limits array.
The valid index should be 0 ~ n_current_limits -1.

Fixes: 99cf3af5e2d5 ("regulator: pv88080: new regulator driver")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/pv88080-regulator.c

index 954a20eeb26f89362be0a4274d364b22a8db3783..a40ecfb77210721cf4484c266ab3bdf06399bf8c 100644 (file)
@@ -279,7 +279,7 @@ static int pv88080_set_current_limit(struct regulator_dev *rdev, int min,
        int i;
 
        /* search for closest to maximum */
-       for (i = info->n_current_limits; i >= 0; i--) {
+       for (i = info->n_current_limits - 1; i >= 0; i--) {
                if (min <= info->current_limits[i]
                        && max >= info->current_limits[i]) {
                                return regmap_update_bits(rdev->regmap,