drm/omap: fix memory leak when FB init fails
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 4 Aug 2017 09:20:03 +0000 (12:20 +0300)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 15 Aug 2017 12:18:25 +0000 (15:18 +0300)
omap_framebuffer_create() fails to unref all the gem objects if creating
the FB fails, leading to a memory leak.

Fix the loop so that it goes through all the reffed gem objects.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/gpu/drm/omapdrm/omap_fb.c

index ddf7a457951be4fecd2c43f18ebdca14d0a58c74..b1a762b70cbf8d1a9410966d8496276075a0db97 100644 (file)
@@ -379,7 +379,7 @@ struct drm_framebuffer *omap_framebuffer_create(struct drm_device *dev,
        return fb;
 
 error:
-       while (--i > 0)
+       while (--i >= 0)
                drm_gem_object_unreference_unlocked(bos[i]);
 
        return fb;