ALSA: emux: Improve a size determination in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 9 Aug 2017 07:11:26 +0000 (09:11 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 10 Aug 2017 15:55:11 +0000 (17:55 +0200)
Replace the specification of data types by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/synth/emux/emux_seq.c

index 53820f75ba3eec5b9ddbc012852c4fafadd915e2..12acf18c5be4daf3eceb2ea5d1bda29cce3f6a55 100644 (file)
@@ -149,7 +149,8 @@ snd_emux_create_port(struct snd_emux *emu, char *name,
                snd_printk(KERN_ERR "no memory\n");
                return NULL;
        }
-       p->chset.channels = kcalloc(max_channels, sizeof(struct snd_midi_channel), GFP_KERNEL);
+       p->chset.channels = kcalloc(max_channels, sizeof(*p->chset.channels),
+                                   GFP_KERNEL);
        if (p->chset.channels == NULL) {
                snd_printk(KERN_ERR "no memory\n");
                kfree(p);
@@ -371,7 +372,7 @@ int snd_emux_init_virmidi(struct snd_emux *emu, struct snd_card *card)
        if (emu->midi_ports <= 0)
                return 0;
 
-       emu->vmidi = kcalloc(emu->midi_ports, sizeof(struct snd_rawmidi *), GFP_KERNEL);
+       emu->vmidi = kcalloc(emu->midi_ports, sizeof(*emu->vmidi), GFP_KERNEL);
        if (emu->vmidi == NULL)
                return -ENOMEM;